-
Notifications
You must be signed in to change notification settings - Fork 198
[CI] Stable stack version override #8352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request does not have a backport label. Could you fix it @pazone? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed, and it looks promising, there are some warnings and nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
@pkoutsovasilis WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR may result in many PRs (1 for each active branch) daily that the product team will have to review and merge, I would ideally like to have the follow-up PR that auto-approves and merges all of the former in case of a green CI (relevant issue), merged in a timely fashion. Given certain priorities and scheduled time-off I would recommend to leave this PR open and merge it when the follow-up issue is already assigned and being worked on. I believe it's more efficient to invest the product team's time if needed and pin the ESS stack version manually rather than introducing more PRs for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see that the follow-up PR is here #8528 and already approved so no reason to delay this one 🙂
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
✅ Backports have been created
|
* [CI] Stable stack version override * Update stable version * Added UpdateCLI config * Added UpdateCLI config * Applied proposed changes * Update branch filter * Update branch filter * Added th action * Improved PR description * improve PR message * Pin version in create_deployment_csp_configuration * Added control plane team label * Remove redundant : * Applied proposed changes * Update test_infra/ess/deployment.tf Co-authored-by: Victor Martinez <[email protected]> * Added fallback to stack_version for docker images * build to .build * Added pipelineid and force * force: false * Enabled automerge --------- Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit e728b39)
* [CI] Stable stack version override * Update stable version * Added UpdateCLI config * Added UpdateCLI config * Applied proposed changes * Update branch filter * Update branch filter * Added th action * Improved PR description * improve PR message * Pin version in create_deployment_csp_configuration * Added control plane team label * Remove redundant : * Applied proposed changes * Update test_infra/ess/deployment.tf Co-authored-by: Victor Martinez <[email protected]> * Added fallback to stack_version for docker images * build to .build * Added pipelineid and force * force: false * Enabled automerge --------- Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit e728b39) # Conflicts: # pkg/testing/ess/create_deployment_csp_configuration.yaml
* [CI] Stable stack version override * Update stable version * Added UpdateCLI config * Added UpdateCLI config * Applied proposed changes * Update branch filter * Update branch filter * Added th action * Improved PR description * improve PR message * Pin version in create_deployment_csp_configuration * Added control plane team label * Remove redundant : * Applied proposed changes * Update test_infra/ess/deployment.tf Co-authored-by: Victor Martinez <[email protected]> * Added fallback to stack_version for docker images * build to .build * Added pipelineid and force * force: false * Enabled automerge --------- Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit e728b39) # Conflicts: # pkg/testing/ess/create_deployment_csp_configuration.yaml
* [CI] Stable stack version override * Update stable version * Added UpdateCLI config * Added UpdateCLI config * Applied proposed changes * Update branch filter * Update branch filter * Added th action * Improved PR description * improve PR message * Pin version in create_deployment_csp_configuration * Added control plane team label * Remove redundant : * Applied proposed changes * Update test_infra/ess/deployment.tf Co-authored-by: Victor Martinez <[email protected]> * Added fallback to stack_version for docker images * build to .build * Added pipelineid and force * force: false * Enabled automerge --------- Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit e728b39) # Conflicts: # pkg/testing/ess/create_deployment_csp_configuration.yaml
What does this PR do?
Pin ESS images versions in
create_deployment_csp_configuration.yaml.Creates a new UpdateCLI pipeline that updates the
.create_deployment_csp_configuration.yamlevery day for every active branch if there's a new stable snapshot available.Tested it on my fork for main and 9.0
Example PRs for main and 9.0
Why is it important?
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself