Skip to content

Conversation

@pazone
Copy link
Contributor

@pazone pazone commented Jun 5, 2025

What does this PR do?

Pin ESS images versions in create_deployment_csp_configuration.yaml.
Creates a new UpdateCLI pipeline that updates the .create_deployment_csp_configuration.yaml every day for every active branch if there's a new stable snapshot available.

Tested it on my fork for main and 9.0
Example PRs for main and 9.0

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added the enhancement New feature or request label Jun 5, 2025
@mergify mergify bot assigned pazone Jun 5, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pazone pazone added backport-active-all Automated backport with mergify to all the active branches Team:Ingest-EngProd skip-changelog labels Jun 5, 2025
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed, and it looks promising, there are some warnings and nits.

@pazone pazone requested a review from v1v June 10, 2025 17:10
@pazone pazone marked this pull request as ready for review June 10, 2025 17:10
@pazone pazone requested review from a team as code owners June 10, 2025 17:10
@pazone pazone requested review from michalpristas and swiatekm June 10, 2025 17:10
swiatekm
swiatekm previously approved these changes Jun 11, 2025
@v1v v1v requested a review from pkoutsovasilis June 11, 2025 09:28
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pazone
Copy link
Contributor Author

pazone commented Jun 16, 2025

@pkoutsovasilis WDYT?

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR may result in many PRs (1 for each active branch) daily that the product team will have to review and merge, I would ideally like to have the follow-up PR that auto-approves and merges all of the former in case of a green CI (relevant issue), merged in a timely fashion. Given certain priorities and scheduled time-off I would recommend to leave this PR open and merge it when the follow-up issue is already assigned and being worked on. I believe it's more efficient to invest the product team's time if needed and pin the ESS stack version manually rather than introducing more PRs for review.

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I see that the follow-up PR is here #8528 and already approved so no reason to delay this one 🙂

@pazone pazone merged commit e728b39 into main Jun 16, 2025
18 checks passed
@pazone pazone deleted the ci_stable_ess_version_autoupdate branch June 16, 2025 15:22
@github-actions
Copy link
Contributor

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2025

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 16, 2025
* [CI] Stable stack version override

* Update stable version

* Added UpdateCLI config

* Added UpdateCLI config

* Applied proposed changes

* Update branch filter

* Update branch filter

* Added th action

* Improved PR description

* improve PR message

* Pin version in create_deployment_csp_configuration

* Added control plane team label

* Remove redundant :

* Applied proposed changes

* Update test_infra/ess/deployment.tf

Co-authored-by: Victor Martinez <[email protected]>

* Added fallback to stack_version for docker images

* build to .build

* Added pipelineid and force

* force: false

* Enabled automerge

---------

Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit e728b39)
mergify bot pushed a commit that referenced this pull request Jun 16, 2025
* [CI] Stable stack version override

* Update stable version

* Added UpdateCLI config

* Added UpdateCLI config

* Applied proposed changes

* Update branch filter

* Update branch filter

* Added th action

* Improved PR description

* improve PR message

* Pin version in create_deployment_csp_configuration

* Added control plane team label

* Remove redundant :

* Applied proposed changes

* Update test_infra/ess/deployment.tf

Co-authored-by: Victor Martinez <[email protected]>

* Added fallback to stack_version for docker images

* build to .build

* Added pipelineid and force

* force: false

* Enabled automerge

---------

Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit e728b39)

# Conflicts:
#	pkg/testing/ess/create_deployment_csp_configuration.yaml
mergify bot pushed a commit that referenced this pull request Jun 16, 2025
* [CI] Stable stack version override

* Update stable version

* Added UpdateCLI config

* Added UpdateCLI config

* Applied proposed changes

* Update branch filter

* Update branch filter

* Added th action

* Improved PR description

* improve PR message

* Pin version in create_deployment_csp_configuration

* Added control plane team label

* Remove redundant :

* Applied proposed changes

* Update test_infra/ess/deployment.tf

Co-authored-by: Victor Martinez <[email protected]>

* Added fallback to stack_version for docker images

* build to .build

* Added pipelineid and force

* force: false

* Enabled automerge

---------

Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit e728b39)

# Conflicts:
#	pkg/testing/ess/create_deployment_csp_configuration.yaml
mergify bot pushed a commit that referenced this pull request Jun 16, 2025
* [CI] Stable stack version override

* Update stable version

* Added UpdateCLI config

* Added UpdateCLI config

* Applied proposed changes

* Update branch filter

* Update branch filter

* Added th action

* Improved PR description

* improve PR message

* Pin version in create_deployment_csp_configuration

* Added control plane team label

* Remove redundant :

* Applied proposed changes

* Update test_infra/ess/deployment.tf

Co-authored-by: Victor Martinez <[email protected]>

* Added fallback to stack_version for docker images

* build to .build

* Added pipelineid and force

* force: false

* Enabled automerge

---------

Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit e728b39)

# Conflicts:
#	pkg/testing/ess/create_deployment_csp_configuration.yaml
v1v added a commit to v1v/elastic-agent that referenced this pull request Jul 8, 2025
mergify bot pushed a commit that referenced this pull request Jul 9, 2025
(cherry picked from commit fb8b883)

# Conflicts:
#	pkg/testing/ess/create_deployment_csp_configuration.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches enhancement New feature or request skip-changelog Team:Ingest-EngProd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants